From aae265bfe1d3aa80daed0ed7e323d0e15efbb6a9 Mon Sep 17 00:00:00 2001 From: John Spray Date: Thu, 26 Mar 2015 12:22:43 +0000 Subject: [PATCH] mds: clarify MDBalancer::send_heartbeat The initial is_degraded() check guarantees that the 'in' set is equal to the 'up' set. Later, this calls get_mds_set and assigns it to a variable called 'up'. It's clearer to use get_up_mds_set into the variable called up (this was confusing when debugging #11218 which was itself a result of is_degraded() ignoring damaged ranks). Signed-off-by: John Spray --- src/mds/MDBalancer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mds/MDBalancer.cc b/src/mds/MDBalancer.cc index 921969146aa5c..ed5a5ca35f200 100644 --- a/src/mds/MDBalancer.cc +++ b/src/mds/MDBalancer.cc @@ -218,7 +218,7 @@ void MDBalancer::send_heartbeat() set up; - mds->get_mds_map()->get_mds_set(up); + mds->get_mds_map()->get_up_mds_set(up); for (set::iterator p = up.begin(); p != up.end(); ++p) { if (*p == mds->get_nodeid()) continue; -- 2.39.5