From ab7344e61755b357c558aef3630e1479d5dcc7b3 Mon Sep 17 00:00:00 2001 From: Changcheng Liu Date: Fri, 26 Oct 2018 14:32:09 +0800 Subject: [PATCH] install-deps.sh: correct gcc version info as major.minor.patch On ubuntu 18.04, "gcc -dumpversion" output "7", it result in that below check will return false: dpkg --compare-versions 7 ge 7.0 Then, this script will install other gcc. Actully, the full gcc version "gcc -dumpfullversion" output is "7.3.0", than below check will turn true: dpkg --compare-version 7.3.0 ge 7.0 So, there's no need to install other gcc. In case of hitting error on ubuntu16.04, use below parameter: gcc -dumpfullversion -dumpversion Signed-off-by: Changcheng Liu --- install-deps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install-deps.sh b/install-deps.sh index da22e54bbae..0ffe8bc2b8d 100755 --- a/install-deps.sh +++ b/install-deps.sh @@ -48,7 +48,7 @@ function munge_ceph_spec_in { function ensure_decent_gcc_on_ubuntu { # point gcc to the one offered by g++-7 if the used one is not # new enough - local old=$(gcc -dumpversion) + local old=$(gcc -dumpfullversion -dumpversion) local new=$1 local codename=$2 if dpkg --compare-versions $old ge 7.0; then -- 2.39.5