From ac73126362f3ea0f26ae32218b86ad9f9ab73670 Mon Sep 17 00:00:00 2001
From: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Date: Thu, 18 May 2023 14:16:10 +0200
Subject: [PATCH] mgr/dashboard: remove title tooltip of cards landing page

Fixes: https://tracker.ceph.com/issues/61250
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
---
 .../src/app/ceph/dashboard-v3/card/card.component.html |  2 +-
 .../app/ceph/dashboard-v3/card/card.component.spec.ts  |  2 +-
 .../src/app/ceph/dashboard-v3/card/card.component.ts   |  2 +-
 .../dashboard-v3/dashboard/dashboard-v3.component.html | 10 +++++-----
 .../dashboard/dashboard-v3.component.spec.ts           |  2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html
index 35dffd46c04..a2f5b9d3d24 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.html
@@ -1,6 +1,6 @@
 <div class="card shadow-sm flex-fill">
   <h4 class="card-title mt-4 ms-4 mb-0">
-    {{ title }}
+    {{ cardTitle }}
   </h4>
   <div class="card-body ps-0 pe-0">
     <ng-content></ng-content>
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts
index fdc34fdf7b2..287e1cfe08f 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.spec.ts
@@ -24,7 +24,7 @@ describe('CardComponent', () => {
 
   it('Setting cards title makes title visible', () => {
     const title = 'Card Title';
-    component.title = title;
+    component.cardTitle = title;
     fixture.detectChanges();
     const titleDiv = fixture.debugElement.nativeElement.querySelector('.card-title');
 
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts
index b6bb99c6690..8e93cc8645c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/card/card.component.ts
@@ -7,5 +7,5 @@ import { Component, Input } from '@angular/core';
 })
 export class CardComponent {
   @Input()
-  title: string;
+  cardTitle: string;
 }
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html
index 2e3fd652d9e..94c1435557c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.html
@@ -1,7 +1,7 @@
 <div class="container-fluid"
      *ngIf="healthData && enabledFeature$ | async as enabledFeature">
   <div class="row mx-0">
-    <cd-card title="Details"
+    <cd-card cardTitle="Details"
              i18n-title
              class="col-sm-3 px-3"
              [ngClass]="{'d-flex': flexHeight}"
@@ -16,7 +16,7 @@
       </dl>
     </cd-card>
 
-    <cd-card title="Status"
+    <cd-card cardTitle="Status"
              i18n-title
              class="col-sm-6 px-3 d-flex"
              aria-label="Status card">
@@ -77,7 +77,7 @@
       </section>
     </cd-card>
 
-    <cd-card title="Capacity"
+    <cd-card cardTitle="Capacity"
              i18n-title
              class="col-sm-3 px-3"
              [ngClass]="{'d-flex': flexHeight}"
@@ -94,7 +94,7 @@
   <!-- Second row -->
   <div class="row mx-0">
     <!-- Inventory Card -->
-    <cd-card title="Inventory"
+    <cd-card cardTitle="Inventory"
              i18n-title
              class="col-sm-3 px-3 d-flex"
              aria-label="Inventory card">
@@ -183,7 +183,7 @@
       </li>
     </cd-card>
 
-    <cd-card title="Cluster utilization"
+    <cd-card cardTitle="Cluster utilization"
              i18n-title
              class="col-sm-9 px-3 d-flex"
              aria-label="Cluster utilization card">
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts
index 677ca35905b..2ca65a468aa 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard/dashboard-v3.component.spec.ts
@@ -225,7 +225,7 @@ describe('Dashbord Component', () => {
 
     getHealthSpy.and.returnValue(of(payload));
     fixture.detectChanges();
-    const clusterStatusCard = fixture.debugElement.query(By.css('cd-card[title="Status"] i'));
+    const clusterStatusCard = fixture.debugElement.query(By.css('cd-card[cardTitle="Status"] i'));
     expect(clusterStatusCard.nativeElement.title).toEqual(`${payload.health.status}`);
 
     // HEALTH_ERR
-- 
2.39.5