From ac7a398f6a6bcb8a11b2f42cc4c5ce30d7122db3 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 11 Jan 2020 22:10:47 +0800 Subject: [PATCH] common/bit_vector.hpp: do not move a temporary object this change also silences a waring from clang: src/common/bit_vector.hpp:278:21: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] m_data.append(std::move(buffer::ptr(buffer_size - m_data.length()))); ^ ../src/common/bit_vector.hpp:278:21: note: remove std::move call here m_data.append(std::move(buffer::ptr(buffer_size - m_data.length()))); ^~~~~~~~~~ ~ Signed-off-by: Kefu Chai --- src/common/bit_vector.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/bit_vector.hpp b/src/common/bit_vector.hpp index 0ffce1b2955..10ee6c3ed6c 100644 --- a/src/common/bit_vector.hpp +++ b/src/common/bit_vector.hpp @@ -275,7 +275,7 @@ void BitVector<_b>::resize(uint64_t size, bool zero) { if (zero) { m_data.append_zero(buffer_size - m_data.length()); } else { - m_data.append(std::move(buffer::ptr(buffer_size - m_data.length()))); + m_data.append(buffer::ptr(buffer_size - m_data.length())); } } else if (buffer_size < m_data.length()) { bufferlist bl; -- 2.39.5