From acd98421eea65032670309b8e96528f55a0b6839 Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Wed, 6 Nov 2019 23:07:20 -0800 Subject: [PATCH] mds: do not register as a service daemon This commit undoes the service daemon registration for the MDS. It doesn't look absolutely necessary and it causes the MDS to be listed twice in the `ceph versions` output: $ ceph versions ... "mds": { "ceph version v15.0.0-6915-g0143b904676 (0143b9046763ea1801efa8358a0c033ec862cea9) octopus (dev)": 3 }, "mds": { "unknown": 3 }, "overall": { "ceph version v15.0.0-6915-g0143b904676 (0143b9046763ea1801efa8358a0c033ec862cea9) octopus (dev)": 10, "unknown": 3 } Fixing that requires looking for duplicates or ignoring MDSs in the service daemons when the mon processes `ceph versions`. I have a feeling that it wasn't actually designed to be used by the MDS this way however. Additionally, the reason for "unknown" version is because the metadata sent to the mgr does not include "ceph_version". Signed-off-by: Patrick Donnelly (cherry picked from commit 046137f819aae72f1423e3feb213f0e46c97c9ce) --- src/mds/MDSRank.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/mds/MDSRank.cc b/src/mds/MDSRank.cc index 669d72e3bfc37..af108a99984fa 100644 --- a/src/mds/MDSRank.cc +++ b/src/mds/MDSRank.cc @@ -552,14 +552,6 @@ MDSRank::MDSRank( op_tracker.set_history_size_and_duration(cct->_conf->mds_op_history_size, cct->_conf->mds_op_history_duration); - std::string rank_str = stringify(get_nodeid()); - std::map service_metadata = {{"rank", rank_str}}; - int r = mgrc->service_daemon_register("mds", cct->_conf->name.get_id(), - service_metadata); - if (r < 0) { - derr << ": failed to register with manager for service status update" << dendl; - } - schedule_update_timer_task(); } -- 2.39.5