From acf1337334faca2ef021294bf7a8367193072484 Mon Sep 17 00:00:00 2001 From: Nikhilkumar Shelke Date: Sun, 12 Jun 2022 21:58:40 +0530 Subject: [PATCH] mgr/volumes: subvolume ls command crashes if groupname as '_nogroup' If --group_name=_nogroup is provided in the command then throw error permission denied as it is internal group of ceph fs. Fixes: https://tracker.ceph.com/issues/55759 Signed-off-by: Nikhilkumar Shelke --- src/pybind/mgr/volumes/fs/operations/group.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pybind/mgr/volumes/fs/operations/group.py b/src/pybind/mgr/volumes/fs/operations/group.py index 152383c51d43..777721d5e412 100644 --- a/src/pybind/mgr/volumes/fs/operations/group.py +++ b/src/pybind/mgr/volumes/fs/operations/group.py @@ -20,7 +20,8 @@ class Group(GroupTemplate): NO_GROUP_NAME = "_nogroup" def __init__(self, fs, vol_spec, groupname): - assert groupname != Group.NO_GROUP_NAME + if groupname == Group.NO_GROUP_NAME: + raise VolumeException(-errno.EPERM, "Operation not permitted for group '{0}' as it is an internal group.".format(groupname)) self.fs = fs self.user_id = None self.group_id = None -- 2.47.3