From ad9fdd15111cd58fbaba7a3c6c2d7121fb55ebab Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Mon, 20 Jul 2009 11:36:23 -0700 Subject: [PATCH] kclient: don't croak on null dev_name As currently caused by bad mount.ceph (mount -t ceph foo:bar mnt). --- src/kernel/super.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/kernel/super.c b/src/kernel/super.c index a3cccf3ef968e..46e33dddba127 100644 --- a/src/kernel/super.c +++ b/src/kernel/super.c @@ -492,9 +492,14 @@ static int parse_mount_args(int flags, char *options, const char *dev_name, args->max_readdir = 1024; /* ip1[:port1][,ip2[:port2]...]:/subdir/in/fs */ + if (!dev_name) + return -EINVAL; c = strstr(dev_name, ":/"); - if (c == NULL) + if (c == NULL) { + pr_err("ceph device name is missing path (no :/ in %s)\n", + dev_name); return -EINVAL; + } *c = 0; /* get mon ip(s) */ -- 2.39.5