From af2114a69b85b0cfdeb69c4c470abbec3eb50758 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Tue, 31 Mar 2020 09:22:43 -0400 Subject: [PATCH] rgw: don't write to error repo for async notification failures async notifications are just hints, and don't imply an obligation to sync the bucket shard. if we fail to sync, don't write it to the error repo for retry. we'll see the change later when processing the datalog Signed-off-by: Casey Bodley --- src/rgw/rgw_data_sync.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rgw/rgw_data_sync.cc b/src/rgw/rgw_data_sync.cc index 94ad515453612..64c6710d9bf1c 100644 --- a/src/rgw/rgw_data_sync.cc +++ b/src/rgw/rgw_data_sync.cc @@ -1658,7 +1658,7 @@ public: for (modified_iter = current_modified.begin(); modified_iter != current_modified.end(); ++modified_iter) { yield { tn->log(20, SSTR("received async update notification: " << *modified_iter)); - spawn(new RGWDataSyncSingleEntryCR(sc, *modified_iter, string(), marker_tracker, error_repo, false, tn), false); + spawn(new RGWDataSyncSingleEntryCR(sc, *modified_iter, string(), marker_tracker, nullptr, false, tn), false); } } -- 2.39.5