From afb604ba7c9e6cc462daa3380ac0f0e341c7c376 Mon Sep 17 00:00:00 2001 From: amitkuma Date: Fri, 4 Aug 2017 20:14:55 +0530 Subject: [PATCH] messages: Initializing uninitialized members MMonProbe Fixes coverity Issue: ** 717299 Uninitialized scalar field 2. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls. 4. uninit_member: Non-static class member paxos_first_version is not initialized in this constructor nor in any functions that it calls. 6. uninit_member: Non-static class member paxos_last_version is not initialized in this constructor nor in any functions that it calls. 8. uninit_member: Non-static class member has_ever_joined is not initialized in this constructor nor in any functions that it calls. CID 717299 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 10. uninit_member: Non-static class member required_features is not initialized in this constructor nor in any functions that it calls Signed-off-by: Amit Kumar amitkuma@redhat.com --- src/messages/MMonProbe.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/messages/MMonProbe.h b/src/messages/MMonProbe.h index 91bf116b9dd5d..c98fc3a759493 100644 --- a/src/messages/MMonProbe.h +++ b/src/messages/MMonProbe.h @@ -47,14 +47,14 @@ public: } uuid_d fsid; - int32_t op; + int32_t op = 0; string name; set quorum; bufferlist monmap_bl; - version_t paxos_first_version; - version_t paxos_last_version; - bool has_ever_joined; - uint64_t required_features; + version_t paxos_first_version = 0; + version_t paxos_last_version = 0; + bool has_ever_joined = 0; + uint64_t required_features = 0; MMonProbe() : Message(MSG_MON_PROBE, HEAD_VERSION, COMPAT_VERSION) {} -- 2.39.5