From b2155c81b91b1bc7d3492ed888caf5e7f65e8d3e Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Tue, 1 Sep 2009 11:03:15 -0700 Subject: [PATCH] mon: subscribe duration in units of seconds, not ms --- src/include/types.h | 2 +- src/messages/MMonSubscribeAck.h | 10 +++++----- src/mon/MonClient.cc | 2 +- src/mon/Monitor.cc | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/include/types.h b/src/include/types.h index 84a63b6aa012e..e3655aed5aa33 100644 --- a/src/include/types.h +++ b/src/include/types.h @@ -387,7 +387,7 @@ inline ostream& operator<<(ostream& out, const kb_t& kb) inline ostream& operator<<(ostream& out, const ceph_mon_subscribe_item& i) { - return out << i.have << (i.onetime ? "(onetime)" : ""); + return out << i.have << (i.onetime ? "" : "+"); } #endif diff --git a/src/messages/MMonSubscribeAck.h b/src/messages/MMonSubscribeAck.h index 3ad4254860e75..ab8889bc3b98f 100644 --- a/src/messages/MMonSubscribeAck.h +++ b/src/messages/MMonSubscribeAck.h @@ -18,22 +18,22 @@ #include "msg/Message.h" struct MMonSubscribeAck : public Message { - __u32 interval_ms; + __u32 interval; MMonSubscribeAck(int i = 0) : Message(CEPH_MSG_MON_SUBSCRIBE_ACK), - interval_ms(i) {} + interval(i) {} const char *get_type_name() { return "mon_subscribe_ack"; } void print(ostream& o) { - o << "mon_subscribe_ack(" << interval_ms << "ms)"; + o << "mon_subscribe_ack(" << interval << "s)"; } void decode_payload() { bufferlist::iterator p = payload.begin(); - ::decode(interval_ms, p); + ::decode(interval, p); } void encode_payload() { - ::encode(interval_ms, payload); + ::encode(interval, payload); } }; diff --git a/src/mon/MonClient.cc b/src/mon/MonClient.cc index a0abf13f71375..8c69ee8ffb68d 100644 --- a/src/mon/MonClient.cc +++ b/src/mon/MonClient.cc @@ -311,7 +311,7 @@ void MonClient::handle_subscribe_ack(MMonSubscribeAck *m) { if (sub_renew_sent != utime_t()) { sub_renew_after = sub_renew_sent; - sub_renew_after += m->interval_ms / 1000.0 / 2.0; + sub_renew_after += m->interval / 2.0; dout(10) << "handle_subscribe_ack sent " << sub_renew_sent << " renew after " << sub_renew_after << dendl; sub_renew_sent = utime_t(); } else { diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc index 76fde7263bb85..f8360d2795117 100644 --- a/src/mon/Monitor.cc +++ b/src/mon/Monitor.cc @@ -514,7 +514,7 @@ void Monitor::handle_subscribe(MMonSubscribe *m) } if (reply) - messenger->send_message(new MMonSubscribeAck(g_conf.mon_subscribe_interval * 1000), + messenger->send_message(new MMonSubscribeAck(g_conf.mon_subscribe_interval), m->get_source_inst()); delete m; -- 2.39.5