From b2960d9bff9faefa9bc3527e49bd6ae6c6dd5c88 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Wed, 8 Jan 2025 14:27:33 +0000 Subject: [PATCH] ceph-volume: add type annotations to devices.lvm.main This commit adds the Python type annotations to `devices.lvm.main`. Signed-off-by: Guillaume Abrioux (cherry picked from commit b460a1a19ef4700dd0d0b2a5dac0a8249f649c19) --- src/ceph-volume/ceph_volume/devices/lvm/main.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/ceph-volume/ceph_volume/devices/lvm/main.py b/src/ceph-volume/ceph_volume/devices/lvm/main.py index 39947454d57f5..7f8c40361a0f3 100644 --- a/src/ceph-volume/ceph_volume/devices/lvm/main.py +++ b/src/ceph-volume/ceph_volume/devices/lvm/main.py @@ -10,9 +10,10 @@ from . import listing from . import zap from . import batch from . import migrate +from typing import List, Optional -class LVM(object): +class LVM: help = 'Use LVM and LVM-based technologies to deploy OSDs' @@ -36,19 +37,21 @@ class LVM(object): 'new-db': migrate.NewDB, } - def __init__(self, argv): + def __init__(self, argv: Optional[List[str]]) -> None: self.argv = argv - def print_help(self, sub_help): + def print_help(self, sub_help: str) -> str: return self._help.format(sub_help=sub_help) - def main(self): + def main(self) -> None: terminal.dispatch(self.mapper, self.argv) parser = argparse.ArgumentParser( prog='ceph-volume lvm', formatter_class=argparse.RawDescriptionHelpFormatter, description=self.print_help(terminal.subhelp(self.mapper)), ) + if self.argv is None: + self.argv = [] parser.parse_args(self.argv) if len(self.argv) <= 1: - return parser.print_help() + parser.print_help() -- 2.39.5