From b37ef49f227ffe6a72c7fe755391142855782d2b Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 19 Mar 2021 19:23:09 +0800 Subject: [PATCH] script/run-make.sh: quote targets with double quote in ceph-build/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml, we pass "vstart-base crimson-osd" as the targets argument, but the build() function in ceph/src/script/run-make.sh fails to quote them, so they are expanded into two argument of `test -n`. hence it breaks like src/script/run-make.sh: line 124: test: vstart-base: binary operator expected make will run with option(s) -j40 Unknown argument vstart-base Unknown argument crimson-osd Signed-off-by: Kefu Chai --- src/script/run-make.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/script/run-make.sh b/src/script/run-make.sh index 7f50fafc9fa6f..9503b8b35bf58 100755 --- a/src/script/run-make.sh +++ b/src/script/run-make.sh @@ -121,7 +121,7 @@ function configure() { function build() { local targets="$@" - if test -n $targets; then + if test -n "$targets"; then targets="--target $targets" fi $DRY_RUN cd build -- 2.39.5