From b5065586e4fa3f219ed7c7af514ad853550e7d77 Mon Sep 17 00:00:00 2001 From: Xuehan Xu Date: Mon, 29 Apr 2024 16:56:09 +0800 Subject: [PATCH] crimson/os/seastore/transaction_manager: remove incorrect assertions Indirect mappings always hold the checksums of the corresponding intermediate mappings, which may have non-zero Signed-off-by: Xuehan Xu (cherry picked from commit fca8efca527f44db63df068751f9e6c8bdc939e2) --- src/crimson/os/seastore/transaction_manager.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/crimson/os/seastore/transaction_manager.h b/src/crimson/os/seastore/transaction_manager.h index 6d99bd77ec2..c7e4121263a 100644 --- a/src/crimson/os/seastore/transaction_manager.h +++ b/src/crimson/os/seastore/transaction_manager.h @@ -885,9 +885,7 @@ private: crc); assert(ref->is_fully_loaded()); bool inconsistent = false; - if (pin->is_indirect()) { - inconsistent = (pin->get_checksum() != 0); - } else if (full_extent_integrity_check) { + if (full_extent_integrity_check) { inconsistent = (pin->get_checksum() != crc); } else { // !full_extent_integrity_check: remapped extent may be skipped inconsistent = !(pin->get_checksum() == 0 || @@ -953,9 +951,7 @@ private: crc); assert(ref->is_fully_loaded()); bool inconsistent = false; - if (pin->is_indirect()) { - inconsistent = (pin->get_checksum() != 0); - } else if (full_extent_integrity_check) { + if (full_extent_integrity_check) { inconsistent = (pin->get_checksum() != crc); } else { // !full_extent_integrity_check: remapped extent may be skipped inconsistent = !(pin->get_checksum() == 0 || -- 2.39.5