From b5e9995f59d363ba00d9cac413d9b754ee44e370 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Fri, 4 May 2012 20:17:26 -0700 Subject: [PATCH] objectcacher: delete unused onfinish from flush_set Once upon a time the caller would do this, but none of those have survived, and this makes more sense. Signed-off-by: Sage Weil --- src/osdc/ObjectCacher.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/osdc/ObjectCacher.cc b/src/osdc/ObjectCacher.cc index 1b20fbe720037..41ed4dd712d98 100644 --- a/src/osdc/ObjectCacher.cc +++ b/src/osdc/ObjectCacher.cc @@ -1427,6 +1427,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, Context *onfinish) { if (oset->objects.empty()) { ldout(cct, 10) << "flush_set on " << oset << " dne" << dendl; + delete onfinish; return true; } @@ -1457,6 +1458,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, Context *onfinish) if (safe) { ldout(cct, 10) << "flush_set " << oset << " has no dirty|tx bhs" << dendl; + delete onfinish; return true; } return false; @@ -1468,6 +1470,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, vector& exv, Context { if (oset->objects.empty()) { ldout(cct, 10) << "flush_set on " << oset << " dne" << dendl; + delete onfinish; return true; } @@ -1503,6 +1506,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, vector& exv, Context if (safe) { ldout(cct, 10) << "flush_set " << oset << " has no dirty|tx bhs" << dendl; + delete onfinish; return true; } return false; -- 2.39.5