From b62c6521fda75e5b39be42e18a95dcad587fc8b8 Mon Sep 17 00:00:00 2001 From: Afreen Date: Wed, 24 Jan 2024 20:39:54 +0530 Subject: [PATCH] mgr/dashboard: Fix issue with Object's Overview page Fixes https://tracker.ceph.com/issues/64150 Issue: Due to absence of null checks, the overview page was failing to load. Fix: Added, null check at relevant places to ensure data availability before accessing the data. Signed-off-by: Afreen --- .../dashboard-area-chart/dashboard-area-chart.component.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard-area-chart/dashboard-area-chart.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard-area-chart/dashboard-area-chart.component.ts index 4a0d95f5421d1..ac0b9ac2ff431 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard-area-chart/dashboard-area-chart.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard-v3/dashboard-area-chart/dashboard-area-chart.component.ts @@ -196,7 +196,7 @@ export class DashboardAreaChartComponent implements OnChanges { this.setChartTicks(); - if (this.dataArray) { + if (this.dataArray && this.dataArray.length && this.dataArray[0] && this.dataArray[0].length) { this.dataArray = changes?.dataArray?.currentValue || this.dataArray; this.currentChartData = this.chartData; for (let index = 0; index < this.dataArray.length; index++) { @@ -223,7 +223,7 @@ export class DashboardAreaChartComponent implements OnChanges { private formatData(array: Array): any { let formattedData = {}; - formattedData = array.map((data: any) => ({ + formattedData = array?.map((data: any) => ({ x: data[0] * 1000, y: Number(this.convertToChartDataUnits(data[1]).replace(/[^\d,.]+/g, '')) })); @@ -290,7 +290,7 @@ export class DashboardAreaChartComponent implements OnChanges { let maxValueDataUnits = ''; const allDataValues = this.dataArray.reduce((array: string[], data) => { - return array.concat(data.map((values: [number, string]) => values[1])); + return array.concat(data?.map((values: [number, string]) => values[1])); }, []); maxValue = Math.max(...allDataValues.map(Number)); -- 2.39.5