From b6cffb9ba426d82a04675e9e63a6e2e6843b7432 Mon Sep 17 00:00:00 2001 From: Ilya Dryomov Date: Wed, 6 Oct 2021 23:14:22 +0200 Subject: [PATCH] librados: OPERATION_BALANCE/LOCALIZE_READS comment is outdated With the introduction of min_last_complete_ondisk on the OSD side, it is safe to use these for non-immutable data. Signed-off-by: Ilya Dryomov --- src/include/rados/librados.hpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/include/rados/librados.hpp b/src/include/rados/librados.hpp index 76fe6dfd0cd69..7c883c33648d0 100644 --- a/src/include/rados/librados.hpp +++ b/src/include/rados/librados.hpp @@ -246,9 +246,11 @@ inline namespace v14_2_0 { /** * These flags apply to the ObjectOperation as a whole. * - * BALANCE_READS and LOCALIZE_READS should only be used - * when reading from data you're certain won't change, - * like a snapshot, or where eventual consistency is ok. + * Prior to octopus BALANCE_READS and LOCALIZE_READS should only + * be used when reading from data you're certain won't change, like + * a snapshot, or where eventual consistency is ok. Since octopus + * (get_min_compatible_osd() >= CEPH_RELEASE_OCTOPUS) both are safe + * for general use. * * ORDER_READS_WRITES will order reads the same way writes are * ordered (e.g., waiting for degraded objects). In particular, it -- 2.39.5