From bb3d091b463dce78f147e9f1333bd667cf2836ed Mon Sep 17 00:00:00 2001 From: John Spray Date: Wed, 13 Dec 2017 13:08:46 +0000 Subject: [PATCH] mgr/balancer: don't use 'foo' tags on commands This looks weird in logs when code elsewhere logs that it didn't handle a command with tag 'foo' Fixes: http://tracker.ceph.com/issues/22361 Signed-off-by: John Spray (cherry picked from commit 432d07a0fe3e9992c21539898ce5be6c6b12a745) --- src/pybind/mgr/balancer/module.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pybind/mgr/balancer/module.py b/src/pybind/mgr/balancer/module.py index b8cc087b9e8..69b3bff9f20 100644 --- a/src/pybind/mgr/balancer/module.py +++ b/src/pybind/mgr/balancer/module.py @@ -873,13 +873,13 @@ class Module(MgrModule): for osd, weight in plan.compat_ws.iteritems(): self.log.info('ceph osd crush weight-set reweight-compat osd.%d %f', osd, weight) - result = CommandResult('foo') + result = CommandResult('') self.send_command(result, 'mon', '', json.dumps({ 'prefix': 'osd crush weight-set reweight-compat', 'format': 'json', 'item': 'osd.%d' % osd, 'weight': [weight], - }), 'foo') + }), '') commands.append(result) # new_weight @@ -888,12 +888,12 @@ class Module(MgrModule): reweightn[str(osd)] = str(int(weight * float(0x10000))) if len(reweightn): self.log.info('ceph osd reweightn %s', reweightn) - result = CommandResult('foo') + result = CommandResult('') self.send_command(result, 'mon', '', json.dumps({ 'prefix': 'osd reweightn', 'format': 'json', 'weights': json.dumps(reweightn), - }), 'foo') + }), '') commands.append(result) # upmap -- 2.47.3