From bb86445e4bcb5526d8bda193a07afc1a43aae36a Mon Sep 17 00:00:00 2001
From: "sjust@redhat.com" <sjust@redhat.com>
Date: Thu, 4 Apr 2019 14:16:50 -0700
Subject: [PATCH] PG: remove direct acting and up references

Signed-off-by: sjust@redhat.com <sjust@redhat.com>
---
 src/osd/PG.cc          | 11 +++++------
 src/osd/PG.h           |  2 --
 src/osd/PeeringState.h |  2 +-
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/osd/PG.cc b/src/osd/PG.cc
index a42768cdde8..db3a22ccd55 100644
--- a/src/osd/PG.cc
+++ b/src/osd/PG.cc
@@ -188,9 +188,7 @@ PG::PG(OSDService *o, OSDMapRef curmap,
   primary(recovery_state.primary),
   pg_whoami(recovery_state.pg_whoami),
   up_primary(recovery_state.up_primary),
-  up(recovery_state.up),
   upset(recovery_state.upset),
-  acting(recovery_state.acting),
   actingset(recovery_state.actingset),
   acting_recovery_backfill(recovery_state.acting_recovery_backfill),
   dirty_info(recovery_state.dirty_info),
@@ -1640,7 +1638,8 @@ bool PG::sched_scrub()
       clear_scrub_reserved();
       scrub_unreserve_replicas();
       ret = false;
-    } else if (scrubber.reserved_peers.size() == acting.size()) {
+    } else if (scrubber.reserved_peers.size() ==
+	       recovery_state.get_acting().size()) {
       dout(20) << "sched_scrub: success, reserved self and replicas" << dendl;
       if (time_for_deep) {
 	dout(10) << "sched_scrub: scrub will be deep" << dendl;
@@ -3207,13 +3206,13 @@ void PG::scrub_compare_maps()
     osd->clog->warn(ss);
   }
 
-  if (acting.size() > 1) {
+  if (recovery_state.get_acting().size() > 1) {
     dout(10) << __func__ << "  comparing replica scrub maps" << dendl;
 
     // Map from object with errors to good peer
     map<hobject_t, list<pg_shard_t>> authoritative;
 
-    dout(2) << __func__ << "   osd." << acting[0] << " has "
+    dout(2) << __func__ << get_primary() << " has "
 	    << scrubber.primary_scrubmap.objects.size() << " items" << dendl;
 
     ss.str("");
@@ -3230,7 +3229,7 @@ void PG::scrub_compare_maps()
       scrubber.shallow_errors,
       scrubber.deep_errors,
       scrubber.store.get(),
-      info.pgid, acting,
+      info.pgid, recovery_state.get_acting(),
       ss);
     dout(2) << ss.str() << dendl;
 
diff --git a/src/osd/PG.h b/src/osd/PG.h
index 1327358d5e9..438beb5e47a 100644
--- a/src/osd/PG.h
+++ b/src/osd/PG.h
@@ -185,9 +185,7 @@ protected:
   pg_shard_t &primary;
   pg_shard_t &pg_whoami;
   pg_shard_t &up_primary;
-  vector<int> &up;
   set<pg_shard_t> &upset;
-  vector<int> &acting;
   set<pg_shard_t> &actingset;
   set<pg_shard_t> &acting_recovery_backfill;
   bool &dirty_info;
diff --git a/src/osd/PeeringState.h b/src/osd/PeeringState.h
index e1f0b611b2d..742cb6a499f 100644
--- a/src/osd/PeeringState.h
+++ b/src/osd/PeeringState.h
@@ -1594,7 +1594,7 @@ public:
   int get_role() const {
     return role;
   }
-  const vector<int> get_acting() const {
+  const vector<int> &get_acting() const {
     return acting;
   }
   int get_acting_primary() const {
-- 
2.39.5