From bc8cc868f9ae2a60144e61763512ead28f868e65 Mon Sep 17 00:00:00 2001 From: Tommi Virtanen Date: Mon, 20 Jun 2011 13:18:01 -0700 Subject: [PATCH] Fix bug that thought all >1 node clusters always had core dumps. Accidentally shared the stdout between all the runs. --- teuthology/task/internal.py | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/teuthology/task/internal.py b/teuthology/task/internal.py index 7722ea63eba87..aa0b71afb645f 100644 --- a/teuthology/task/internal.py +++ b/teuthology/task/internal.py @@ -171,16 +171,15 @@ def coredump(ctx, config): # set success=false if the dir is still there = coredumps were # seen - processes = ctx.cluster.run( - args=[ - 'if', 'test', '!', '-e', '/tmp/cephtest/archive/coredump', run.Raw(';'), 'then', - 'echo', 'OK', run.Raw(';'), - 'fi', - ], - wait=False, - stdout=StringIO(), - ) - run.wait(processes) - if any(r.stdout.getvalue() != 'OK' for r in processes): - log.warning('Found coredumps, flagging run as failed.') - ctx.summary['success'] = False + for remote in ctx.cluster.remotes.iterkeys(): + r = remote.run( + args=[ + 'if', 'test', '!', '-e', '/tmp/cephtest/archive/coredump', run.Raw(';'), 'then', + 'echo', 'OK', run.Raw(';'), + 'fi', + ], + stdout=StringIO(), + ) + if r.stdout.getvalue() != 'OK\n': + log.warning('Found coredumps on %s, flagging run as failed', remote) + ctx.summary['success'] = False -- 2.39.5