From bdaa90aae7fc3df064ab7f9d695c25e9fa9c4e8e Mon Sep 17 00:00:00 2001 From: Murphy Zhou Date: Wed, 25 Aug 2021 11:26:30 +0800 Subject: [PATCH] generic: check log recovery with readonly mount And followed by a rw mount. After log recovery by these 2 mounts, the filesystem should be in a consistent state. Suggested-by: Donald Douwsma Reviewed-by: Darrick J. Wong Signed-off-by: Murphy Zhou Reviewed-by: Zorro Lang Signed-off-by: Eryu Guan --- tests/generic/646 | 42 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/646.out | 2 ++ 2 files changed, 44 insertions(+) create mode 100755 tests/generic/646 create mode 100644 tests/generic/646.out diff --git a/tests/generic/646 b/tests/generic/646 new file mode 100755 index 00000000..79d3f17c --- /dev/null +++ b/tests/generic/646 @@ -0,0 +1,42 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2021 RedHat All Rights Reserved. +# +# FS QA Test No. 646 +# +# Testcase for kernel commit: +# 50d25484bebe xfs: sync lazy sb accounting on quiesce of read-only mounts +# +# After shutdown and readonly mount, a following read-write mount would +# get wrong number of available blocks. This is caused by unmounting the log +# on a readonly filesystem doesn't log the sb counters. +# +. ./common/preamble +_begin_fstest auto quick recoveryloop shutdown + +# real QA test starts here + +_require_scratch +_require_scratch_shutdown +_scratch_mkfs > $seqres.full 2>&1 + +_scratch_mount +[ "$FSTYP" == "xfs" ] && _xfs_force_bdev data $SCRATCH_MNT + +echo Testing > $SCRATCH_MNT/testfile + +# -f is required to reproduce the original issue +_scratch_shutdown -f + +_scratch_cycle_mount ro +_scratch_cycle_mount + +# These two mounts should have the log fully recovered. Exit here and let the +# fsck operation of xfstests to check the consistence of the tested filesystem. +# On the buggy kernel, this testcase reports filesystem is inconsistent. +# On the fixed kernel, testcase pass. + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/generic/646.out b/tests/generic/646.out new file mode 100644 index 00000000..8357006e --- /dev/null +++ b/tests/generic/646.out @@ -0,0 +1,2 @@ +QA output created by 646 +Silence is golden -- 2.39.5