From bf9a07bf12407ca3e1daebd92107d6aaa1db4915 Mon Sep 17 00:00:00 2001 From: Mykola Golub Date: Tue, 5 Feb 2019 10:39:53 +0000 Subject: [PATCH] rados: provide user with more meaningful error message when trying to mksnap on a pool in the selfmanaged snaps mode. Previously the error message in this case was: error creating pool XYZ snapshot ABC: (22) Invalid argument which was highly uninformative. Signed-off-by: Mykola Golub --- src/tools/rados/rados.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/tools/rados/rados.cc b/src/tools/rados/rados.cc index 9774dfdede6..37c6d3352e0 100644 --- a/src/tools/rados/rados.cc +++ b/src/tools/rados/rados.cc @@ -3090,6 +3090,12 @@ static int rados_tool_common(const std::map < std::string, std::string > &opts, return 1; } + if (rados.get_pool_is_selfmanaged_snaps_mode(pool_name)) { + cerr << "can't create snapshot: pool " << pool_name + << " is in selfmanaged snaps mode" << std::endl; + return 1; + } + ret = io_ctx.snap_create(nargs[1]); if (ret < 0) { cerr << "error creating pool " << pool_name << " snapshot " << nargs[1] -- 2.39.5