From bfe7a2afaa5f41e785590d6315313553cadaf7dc Mon Sep 17 00:00:00 2001 From: Willem Jan Withagen Date: Thu, 6 Sep 2018 11:10:32 +0200 Subject: [PATCH] test: Start using GNU awk and fix archiving directory awk uses some tests that the native FreeBSD awk does not support: like: BEGIN{print 0 < 90} And TESTDIR is not set when calling ceph-helpers from smoke.sh So fix with keeping the archive in /tmp Signed-off-by: Willem Jan Withagen --- install-deps.sh | 1 + qa/standalone/ceph-helpers.sh | 14 +++++++++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/install-deps.sh b/install-deps.sh index 7a8aa07f2284d..8f118b9466212 100755 --- a/install-deps.sh +++ b/install-deps.sh @@ -162,6 +162,7 @@ if [ x$(uname)x = xFreeBSDx ]; then net/socat \ textproc/expat2 \ textproc/gsed \ + lang/gawk \ textproc/libxml2 \ textproc/xmlstarlet \ textproc/jq \ diff --git a/qa/standalone/ceph-helpers.sh b/qa/standalone/ceph-helpers.sh index e68425cba1952..111536c89fe16 100755 --- a/qa/standalone/ceph-helpers.sh +++ b/qa/standalone/ceph-helpers.sh @@ -21,7 +21,9 @@ TIMEOUT=300 WAIT_FOR_CLEAN_TIMEOUT=90 MAX_TIMEOUT=15 PG_NUM=4 -CEPH_BUILD_VIRTUALENV=${TMPDIR:-/tmp} +TMPDIR=${TMPDIR:-/tmp} +CEPH_BUILD_VIRTUALENV=${TMPDIR} +TESTDIR=${TESTDIR:-${TMPDIR}} if type xmlstarlet > /dev/null 2>&1; then XMLSTARLET=xmlstarlet @@ -34,10 +36,12 @@ fi if [ `uname` = FreeBSD ]; then SED=gsed + AWK=gawk DIFFCOLOPTS="" KERNCORE="kern.corefile" else SED=sed + AWK=awk termwidth=$(stty -a | head -1 | sed -e 's/.*columns \([0-9]*\).*/\1/') if [ -n "$termwidth" -a "$termwidth" != "0" ]; then termwidth="-W ${termwidth}" @@ -202,8 +206,8 @@ function teardown() { function __teardown_btrfs() { local btrfs_base_dir=$1 - local btrfs_root=$(df -P . | tail -1 | awk '{print $NF}') - local btrfs_dirs=$(cd $btrfs_base_dir; sudo btrfs subvolume list -t . | awk '/^[0-9]/ {print $4}' | grep "$btrfs_base_dir/$btrfs_dir") + local btrfs_root=$(df -P . | tail -1 | $AWK '{print $NF}') + local btrfs_dirs=$(cd $btrfs_base_dir; sudo btrfs subvolume list -t . | $AWK '/^[0-9]/ {print $4}' | grep "$btrfs_base_dir/$btrfs_dir") for subvolume in $btrfs_dirs; do sudo btrfs subvolume delete $btrfs_root/$subvolume done @@ -1408,7 +1412,7 @@ function test_is_clean() { ####################################################################### -calc() { awk "BEGIN{print $*}"; } +calc() { $AWK "BEGIN{print $*}"; } ## # Return a list of numbers that are increasingly larger and whose @@ -1825,7 +1829,7 @@ function run_in_background() { local pid_variable=$1 shift # Execute the command and prepend the output with its pid - # We enforce to return the exit status of the command and not the awk one. + # We enforce to return the exit status of the command and not the sed one. ("$@" |& sed 's/^/'$$': /'; return "${PIPESTATUS[0]}") >&2 & eval "$pid_variable+=\" $!\"" } -- 2.39.5