From c070796fc661e1f881a2ceb0bd0ce32ed0494c53 Mon Sep 17 00:00:00 2001 From: Tatjana Dehler Date: Fri, 24 Jan 2020 17:02:22 +0100 Subject: [PATCH] mgr/dashboard: show checkboxes for booleans The frontend showed textboxes for the dashboard settings because the actual type information was missing here. The REST API then returned the default type 'str'. Edit the e2e test case in order to update a different setting as the 'editMgrModule' method can't handle checkboxes. Fixes: https://tracker.ceph.com/issues/43769 Signed-off-by: Tatjana Dehler (cherry picked from commit 7e7cac98116e76bc9e4c52ac47796e3fcd880667) --- src/pybind/mgr/dashboard/settings.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pybind/mgr/dashboard/settings.py b/src/pybind/mgr/dashboard/settings.py index bda0dda04133d..31e09fac5ed21 100644 --- a/src/pybind/mgr/dashboard/settings.py +++ b/src/pybind/mgr/dashboard/settings.py @@ -153,7 +153,8 @@ def options_schema_list(): for option, value in inspect.getmembers(Options, filter_attr): if option.startswith('_'): continue - result.append({'name': option, 'default': value[0]}) + result.append({'name': option, 'default': value[0], + 'type': value[1].__name__}) return result -- 2.39.5