From c119091ef0844e4a1ddd790a8bfef8f06bb57d58 Mon Sep 17 00:00:00 2001 From: Brad Hubbard Date: Tue, 21 Mar 2017 12:22:20 +1000 Subject: [PATCH] tools/rados: Check return value of connect Fail gracefully if Rados::connect returns an error. Fixes: http://tracker.ceph.com/issues/19319 Signed-off-by: Brad Hubbard --- src/tools/rados/RadosImport.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/tools/rados/RadosImport.cc b/src/tools/rados/RadosImport.cc index 0f27e1c6db7..d437535268b 100644 --- a/src/tools/rados/RadosImport.cc +++ b/src/tools/rados/RadosImport.cc @@ -43,7 +43,11 @@ int RadosImport::import(std::string pool, bool no_overwrite) cerr << "Error " << ret << " in cluster.conf_read_env" << std::endl; return ret; } - cluster.connect(); + ret = cluster.connect(); + if (ret) { + cerr << "Error " << ret << " in cluster.connect" << std::endl; + return ret; + } ret = cluster.ioctx_create(pool.c_str(), ioctx); if (ret < 0) { -- 2.39.5