From c1ffe08c184814681e5d87f5ea55c9a88580c8a4 Mon Sep 17 00:00:00 2001 From: Josh Durgin Date: Mon, 24 Sep 2012 13:19:59 -0700 Subject: [PATCH] librbd: init everything in default AioRequest constructors CID 717222: Uninitialized pointer field (UNINIT_CTOR) At (16): Non-static class member "m_hide_enoent" is not initialized in this constructor nor in any functions that it calls. CID 717223: Uninitialized scalar field (UNINIT_CTOR) At (4): Non-static class member "m_has_parent" is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Josh Durgin --- src/librbd/AioRequest.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/librbd/AioRequest.cc b/src/librbd/AioRequest.cc index 610fe63b9bb8d..f8a82236927ca 100644 --- a/src/librbd/AioRequest.cc +++ b/src/librbd/AioRequest.cc @@ -17,7 +17,10 @@ namespace librbd { - AioRequest::AioRequest() {} + AioRequest::AioRequest() : + m_ictx(NULL), m_image_ofs(0), m_block_ofs(0), m_len(0), + m_snap_id(CEPH_NOSNAP), m_completion(NULL), m_parent_completion(NULL), + m_hide_enoent(false) {} AioRequest::AioRequest(ImageCtx *ictx, const std::string &oid, uint64_t image_ofs, size_t len, librados::snap_t snap_id, @@ -95,7 +98,8 @@ namespace librbd { return r; } - AbstractWrite::AbstractWrite() {} + AbstractWrite::AbstractWrite() : + m_state(LIBRBD_AIO_WRITE_FINAL), m_has_parent(false) {} AbstractWrite::AbstractWrite(ImageCtx *ictx, const std::string &oid, uint64_t image_ofs, size_t len, librados::snap_t snap_id, Context *completion, -- 2.39.5