From c220207d86ec69ae4312f4629df80f7a4e35b321 Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Thu, 12 Apr 2018 10:21:05 -0700 Subject: [PATCH] common: ignore errors during preforker exit Caller can't do anything useful and it obsecures the error the caller wants to return. Signed-off-by: Patrick Donnelly (cherry picked from commit 3f0b7d96f5cb96ff61c935777671ab7ddd94cfd3) --- src/common/Preforker.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/common/Preforker.h b/src/common/Preforker.h index 9fe34e5ea0eb8..f6671a5d302d6 100644 --- a/src/common/Preforker.h +++ b/src/common/Preforker.h @@ -107,11 +107,8 @@ public: int signal_exit(int r) { if (forked) { - // tell parent. this shouldn't fail, but if it does, pass the - // error back to the parent. - int ret = safe_write(fd[1], &r, sizeof(r)); - if (ret <= 0) - return ret; + /* If we get an error here, it's too late to do anything reasonable about it. */ + (void)safe_write(fd[1], &r, sizeof(r)); } return r; } -- 2.39.5