From c47f73d7152467ff89866efaafc4d77e34b62b25 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 5 Apr 2020 23:30:13 +0800 Subject: [PATCH] qa/tasks/cephfs: cast mds_recall_warning_decay_rate to float this change should address the failure of ``` 2020-04-05T15:14:23.088 INFO:tasks.cephfs_test_runner:Traceback (most recent call last): 2020-04-05T15:14:23.088 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_tchaikov_ceph_wip-qa-py3/qa/tasks/cephfs/test_client_limits.py", line 110, in test_client_pin_mincaps 2020-04-05T15:14:23.089 INFO:tasks.cephfs_test_runner: self._test_client_pin(True, 200) 2020-04-05T15:14:23.089 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_tchaikov_ceph_wip-qa-py3/qa/tasks/cephfs/test_client_limits.py", line 71, in _test_client_pin 2020-04-05T15:14:23.090 INFO:tasks.cephfs_test_runner: self.wait_for_health("MDS_CLIENT_RECALL", mds_recall_warning_decay_rate*2) 2020-04-05T15:14:23.091 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_tchaikov_ceph_wip-qa-py3/qa/tasks/ceph_test_case.py", line 152, in wait_for_health 2020-04-05T15:14:23.091 INFO:tasks.cephfs_test_runner: self.wait_until_true(seen_health_warning, timeout) 2020-04-05T15:14:23.092 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/github.com_tchaikov_ceph_wip-qa-py3/qa/tasks/ceph_test_case.py", line 193, in wait_until_true 2020-04-05T15:14:23.093 INFO:tasks.cephfs_test_runner: if elapsed >= timeout: 2020-04-05T15:14:23.093 INFO:tasks.cephfs_test_runner:TypeError: unorderable types: int() >= str() ``` Signed-off-by: Kefu Chai (cherry picked from commit 162be9210613a4b4a921fa0ff285c869548d7d49) --- qa/tasks/cephfs/test_client_limits.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qa/tasks/cephfs/test_client_limits.py b/qa/tasks/cephfs/test_client_limits.py index 6100fbf6dcaef..f23c00b2a7bc7 100644 --- a/qa/tasks/cephfs/test_client_limits.py +++ b/qa/tasks/cephfs/test_client_limits.py @@ -50,7 +50,7 @@ class TestClientLimits(CephFSTestCase): mds_min_caps_per_client = int(self.fs.get_config("mds_min_caps_per_client")) mds_max_caps_per_client = int(self.fs.get_config("mds_max_caps_per_client")) - mds_recall_warning_decay_rate = self.fs.get_config("mds_recall_warning_decay_rate") + mds_recall_warning_decay_rate = float(self.fs.get_config("mds_recall_warning_decay_rate")) self.assertTrue(open_files >= mds_min_caps_per_client) mount_a_client_id = self.mount_a.get_global_id() -- 2.39.5