From c658258d9e2f590054a30c0dee14a579a51bda8c Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Tue, 15 Oct 2013 13:11:29 -0700 Subject: [PATCH] OSD: ping tphandle during pg removal Fixes: #6528 Signed-off-by: Samuel Just Reviewed-by: Sage Weil --- src/osd/OSD.cc | 15 ++++++++++++--- src/osd/OSD.h | 2 +- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index b2aa2ebbcd219..d450fd543e6b0 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -3278,13 +3278,15 @@ bool remove_dir( ObjectStore *store, SnapMapper *mapper, OSDriver *osdriver, ObjectStore::Sequencer *osr, - coll_t coll, DeletingStateRef dstate) + coll_t coll, DeletingStateRef dstate, + ThreadPool::TPHandle &handle) { vector olist; int64_t num = 0; ObjectStore::Transaction *t = new ObjectStore::Transaction; ghobject_t next; while (!next.is_max()) { + handle.reset_tp_timeout(); store->collection_list_partial( coll, next, @@ -3306,7 +3308,9 @@ bool remove_dir( C_SaferCond waiter; store->queue_transaction(osr, t, &waiter); bool cont = dstate->pause_clearing(); + handle.suspend_tp_timeout(); waiter.wait(); + handle.reset_tp_timeout(); if (cont) cont = dstate->resume_clearing(); delete t; @@ -3322,14 +3326,18 @@ bool remove_dir( C_SaferCond waiter; store->queue_transaction(osr, t, &waiter); bool cont = dstate->pause_clearing(); + handle.suspend_tp_timeout(); waiter.wait(); + handle.reset_tp_timeout(); if (cont) cont = dstate->resume_clearing(); delete t; return cont; } -void OSD::RemoveWQ::_process(pair item) +void OSD::RemoveWQ::_process( + pair item, + ThreadPool::TPHandle &handle) { PGRef pg(item.first); SnapMapper &mapper = pg->snap_mapper; @@ -3346,7 +3354,8 @@ void OSD::RemoveWQ::_process(pair item) i != colls_to_remove.end(); ++i) { bool cont = remove_dir( - pg->cct, store, &mapper, &driver, pg->osr.get(), *i, item.second); + pg->cct, store, &mapper, &driver, pg->osr.get(), *i, item.second, + handle); if (!cont) return; } diff --git a/src/osd/OSD.h b/src/osd/OSD.h index 9346cee6890a9..f7559da3be53a 100644 --- a/src/osd/OSD.h +++ b/src/osd/OSD.h @@ -1681,7 +1681,7 @@ protected: remove_queue.pop_front(); return item; } - void _process(pair); + void _process(pair, ThreadPool::TPHandle &); void _clear() { remove_queue.clear(); } -- 2.39.5