From c6779fdf1332d1ce9e257c39db805d0eabecddc6 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Fri, 3 Sep 2021 11:38:04 +0200 Subject: [PATCH] qa/tox.ini: check for dead symlinks IMO the amount of symlinks we have to manually maintain is tedious and error prone. Any ideas on improving thing? Signed-off-by: Sebastian Wagner --- qa/CMakeLists.txt | 2 +- qa/suites/rgw-multisite-upgrade/.qa | 1 + qa/tox.ini | 9 ++++++++- 3 files changed, 10 insertions(+), 2 deletions(-) create mode 120000 qa/suites/rgw-multisite-upgrade/.qa diff --git a/qa/CMakeLists.txt b/qa/CMakeLists.txt index 884c41e4bbafe..b8d4872ac0e15 100644 --- a/qa/CMakeLists.txt +++ b/qa/CMakeLists.txt @@ -5,5 +5,5 @@ endif() if(WITH_TESTS) include(AddCephTest) - add_tox_test(qa TOX_ENVS py3 flake8 mypy) + add_tox_test(qa TOX_ENVS py3 flake8 mypy deadsymlinks) endif() diff --git a/qa/suites/rgw-multisite-upgrade/.qa b/qa/suites/rgw-multisite-upgrade/.qa new file mode 120000 index 0000000000000..fea2489fdf6d9 --- /dev/null +++ b/qa/suites/rgw-multisite-upgrade/.qa @@ -0,0 +1 @@ +../.qa \ No newline at end of file diff --git a/qa/tox.ini b/qa/tox.ini index 1046597ac1661..6d5ae7ecba6b1 100644 --- a/qa/tox.ini +++ b/qa/tox.ini @@ -1,5 +1,5 @@ [tox] -envlist = flake8, mypy, pytest +envlist = flake8, mypy, pytest, deadsymlinks skipsdist = True [testenv:flake8] @@ -31,3 +31,10 @@ commands = pytest --assert=plain test_import.py pytest tasks/tests +[testenv:deadsymlinks] +basepython = python3 +toxworkdir = {toxinidir} +allowlist_externals = + bash +commands = + bash -c '! (find . -xtype l | grep ^)' -- 2.39.5