From c68175fba57b19e9a9afb1d7950567feb226c78b Mon Sep 17 00:00:00 2001
From: Matan Breizman <mbreizma@redhat.com>
Date: Sun, 8 Jun 2025 10:20:25 +0000
Subject: [PATCH] crimson/CMakeLists: simplify crimson-common deps

instead of appending conditional dependencies to crimson-common with
crimson_common_deps and crimson_common_public_deps, use
target_link_libraries directly.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---
 src/crimson/CMakeLists.txt | 27 +++++++--------------------
 1 file changed, 7 insertions(+), 20 deletions(-)

diff --git a/src/crimson/CMakeLists.txt b/src/crimson/CMakeLists.txt
index edeb04a1d802d..0af1a6fd4634b 100644
--- a/src/crimson/CMakeLists.txt
+++ b/src/crimson/CMakeLists.txt
@@ -126,30 +126,17 @@ target_compile_definitions(crimson-common PRIVATE
   "CEPH_INSTALL_FULL_PKGLIBDIR=\"${CEPH_INSTALL_FULL_PKGLIBDIR}\""
   "CEPH_INSTALL_DATADIR=\"${CEPH_INSTALL_DATADIR}\"")
 
-set(crimson_common_deps
-  Boost::iostreams
-  Boost::random
-  json_spirit)
-
-set(crimson_common_public_deps crimson::cflags)
-if(WITH_JAEGER)
-  list(APPEND crimson_common_public_deps jaeger_base)
-endif()
-
-if(WITH_BREAKPAD)
-  list(APPEND crimson_common_deps Breakpad::client)
-endif()
-
-if(NOT WITH_SYSTEM_BOOST)
-  list(APPEND crimson_common_deps ${ZLIB_LIBRARIES})
-endif()
-
 target_link_libraries(crimson-common
   PUBLIC
-    ${crimson_common_public_deps}
+    $<$<BOOL:${WITH_JAEGER}>:jaeger_base>
+    crimson::cflags
   PRIVATE
     crc32 arch
-    ${crimson_common_deps}
+    Boost::iostreams
+    Boost::random
+    json_spirit
+    $<$<NOT:$<BOOL:${WITH_SYSTEM_BOOST}>>:${ZLIB_LIBRARIES}>
+    $<$<BOOL:${WITH_BREAKPAD}>:Breakpad::client>
     OpenSSL::Crypto)
 
 set(crimson_auth_srcs
-- 
2.39.5