From c683fa876cac773876c68b2fcce51d0ea6fe06fd Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Tue, 25 Sep 2012 13:45:51 -0700 Subject: [PATCH] OSD: big parameter passed by value, send_still_alive CID 717050: Big parameter passed by value (PASS_BY_VALUE)At (1): Passing parameter i of type entity_inst_t (size 152 bytes) by value. Signed-off-by: Samuel Just --- src/osd/OSD.cc | 2 +- src/osd/OSD.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index 42fb43d54214..19d2010d3fd4 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -2484,7 +2484,7 @@ void OSD::send_failures() if (locked) heartbeat_lock.Unlock(); } -void OSD::send_still_alive(epoch_t epoch, entity_inst_t i) +void OSD::send_still_alive(epoch_t epoch, const entity_inst_t &i) { MOSDFailure *m = new MOSDFailure(monc->get_fsid(), i, 0, epoch); m->is_failed = false; diff --git a/src/osd/OSD.h b/src/osd/OSD.h index 2fb4b2ce2252..dc8b8daad706 100644 --- a/src/osd/OSD.h +++ b/src/osd/OSD.h @@ -832,7 +832,7 @@ protected: void send_failures(); - void send_still_alive(epoch_t epoch, entity_inst_t i); + void send_still_alive(epoch_t epoch, const entity_inst_t &i); // -- pg stats -- Mutex pg_stat_queue_lock; -- 2.47.3