From c6dd47ab6d1ec6784ec3cef8f65139baeaf4fa3a Mon Sep 17 00:00:00 2001 From: Andrew Schoen Date: Thu, 19 Oct 2017 10:35:10 -0500 Subject: [PATCH] ceph-volume: api.lvm.remove_lv should return True when successful Signed-off-by: Andrew Schoen (cherry picked from commit 7f055aa6deb3904cf0334e214c13a26098b08aa8) --- src/ceph-volume/ceph_volume/api/lvm.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ceph-volume/ceph_volume/api/lvm.py b/src/ceph-volume/ceph_volume/api/lvm.py index 8b824f5da58..9c384ce09ca 100644 --- a/src/ceph-volume/ceph_volume/api/lvm.py +++ b/src/ceph-volume/ceph_volume/api/lvm.py @@ -216,6 +216,9 @@ def create_vg(name, *devices): def remove_lv(path): """ Removes a logical volume given it's absolute path. + + Will return True if the lv is successfully removed or + raises a RuntimeError if the removal fails. """ stdout, stderr, returncode = process.call( [ @@ -230,6 +233,7 @@ def remove_lv(path): ) if returncode != 0: raise RuntimeError("Unable to remove %s".format(path)) + return True def create_lv(name, group, size=None, tags=None): -- 2.47.3