From c7f92d9a8cd972536800d30dd997d4555f76d6d7 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 21 Aug 2020 15:44:59 +0800 Subject: [PATCH] crimson/osd: avoid creating a throw-away object for better readabilty and performnce Signed-off-by: Kefu Chai --- src/crimson/osd/pg_backend.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/crimson/osd/pg_backend.cc b/src/crimson/osd/pg_backend.cc index e46c9372f7e..cd08b87edc8 100644 --- a/src/crimson/osd/pg_backend.cc +++ b/src/crimson/osd/pg_backend.cc @@ -757,13 +757,11 @@ seastar::future<> PGBackend::setxattr( maybe_create_new_object(os, txn); - std::string name; + std::string name{"_"}; ceph::bufferlist val; { auto bp = osd_op.indata.cbegin(); - std::string aname; - bp.copy(osd_op.op.xattr.name_len, aname); - name = "_" + aname; + bp.copy(osd_op.op.xattr.name_len, name); bp.copy(osd_op.op.xattr.value_len, val); osd_op.indata.splice(0, bp.get_off()); } -- 2.39.5