From c915f9a46c9f351c48a50ea21bb2dd7dc3afe7bb Mon Sep 17 00:00:00 2001
From: Volker Theile <vtheile@suse.com>
Date: Thu, 29 Nov 2018 13:04:14 +0100
Subject: [PATCH] Add a unit test that tests the
 ceph_volume.devices.lvm.batch.Batch::get_devices method.

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 19a38189fd15f57907449631a0f6e9faf908dc66)
---
 .../tests/devices/lvm/test_batch.py           | 50 ++++++++++++++++++-
 1 file changed, 49 insertions(+), 1 deletion(-)

diff --git a/src/ceph-volume/ceph_volume/tests/devices/lvm/test_batch.py b/src/ceph-volume/ceph_volume/tests/devices/lvm/test_batch.py
index 5650e15e09056..7ad77ab1ef096 100644
--- a/src/ceph-volume/ceph_volume/tests/devices/lvm/test_batch.py
+++ b/src/ceph-volume/ceph_volume/tests/devices/lvm/test_batch.py
@@ -1,12 +1,60 @@
 from ceph_volume.devices.lvm import batch
 
 
-class TestBatchSmoke(object):
+class TestBatch(object):
 
     def test_batch_instance(self, is_root):
         b = batch.Batch([])
         b.main()
 
+    def test_get_devices(self, monkeypatch):
+        return_value = {
+            '/dev/vdd': {
+                'removable': '0',
+                'vendor': '0x1af4',
+                'model': '',
+                'sas_address': '',
+                'sas_device_handle': '',
+                'sectors': 0,
+                'size': 21474836480.0,
+                'support_discard': '',
+                'partitions': {
+                    'vdd1': {
+                        'start': '2048',
+                        'sectors': '41940959',
+                        'sectorsize': 512,
+                        'size': '20.00 GB'
+                    }
+                },
+                'rotational': '1',
+                'scheduler_mode': 'mq-deadline',
+                'sectorsize': '512',
+                'human_readable_size': '20.00 GB',
+                'path': '/dev/vdd'
+            },
+            '/dev/vdf': {
+                'removable': '0',
+                'vendor': '0x1af4',
+                'model': '',
+                'sas_address': '',
+                'sas_device_handle': '',
+                'sectors': 0,
+                'size': 21474836480.0,
+                'support_discard': '',
+                'partitions': {},
+                'rotational': '1',
+                'scheduler_mode': 'mq-deadline',
+                'sectorsize': '512',
+                'human_readable_size': '20.00 GB',
+                'path': '/dev/vdf'
+            }
+        }
+        monkeypatch.setattr('ceph_volume.devices.lvm.batch.disk.get_devices',
+                            lambda: return_value)
+        b = batch.Batch([])
+        result = b.get_devices().strip()
+        assert result == '* /dev/vdf                  20.00 GB   rotational'
+
 
 class TestFilterDevices(object):
 
-- 
2.39.5