From c9bdfdc1a4272303a65e8e5f3e465136de6073ab Mon Sep 17 00:00:00 2001 From: Radoslaw Zarzynski Date: Wed, 26 Oct 2022 11:50:22 +0000 Subject: [PATCH] crimson/osd: move the SnapTrimmer-related handlers of PeeringState from .h to .cc This commit is solely about code shuffling. Signed-off-by: Radoslaw Zarzynski --- src/crimson/osd/pg.cc | 16 ++++++++++++++++ src/crimson/osd/pg.h | 13 +++---------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc index 822c7754fb7..679099a9272 100644 --- a/src/crimson/osd/pg.cc +++ b/src/crimson/osd/pg.cc @@ -429,6 +429,22 @@ PG::do_delete_work(ceph::os::Transaction &t, ghobject_t _next) } } +Context *PG::on_clean() +{ + // Not needed yet (will be needed for IO unblocking) + return nullptr; +} + +void PG::on_active_actmap() +{ + // Not needed yet +} + +void PG::on_active_advmap(const OSDMapRef &osdmap) +{ + // Not needed yet +} + void PG::scrub_requested(scrub_level_t scrub_level, scrub_type_t scrub_type) { // TODO: should update the stats upon finishing the scrub diff --git a/src/crimson/osd/pg.h b/src/crimson/osd/pg.h index 992d0e89754..dd013e8db74 100644 --- a/src/crimson/osd/pg.h +++ b/src/crimson/osd/pg.h @@ -332,10 +332,7 @@ public: void on_new_interval() final { // Not needed yet } - Context *on_clean() final { - // Not needed yet (will be needed for IO unblocking) - return nullptr; - } + Context *on_clean() final; void on_activate_committed() final { // Not needed yet (will be needed for IO unblocking) } @@ -355,12 +352,8 @@ public: void set_ready_to_merge_target(eversion_t lu, epoch_t les, epoch_t lec) final {} void set_ready_to_merge_source(eversion_t lu) final {} - void on_active_actmap() final { - // Not needed yet - } - void on_active_advmap(const OSDMapRef &osdmap) final { - // Not needed yet - } + void on_active_actmap() final; + void on_active_advmap(const OSDMapRef &osdmap) final; epoch_t cluster_osdmap_trim_lower_bound() final { // TODO -- 2.39.5