From c9f7689a7a71a6b2321301b84599f319e8ae8eba Mon Sep 17 00:00:00 2001 From: Andrew Schoen Date: Wed, 17 Jan 2018 11:44:10 -0600 Subject: [PATCH] ceph-volume: print the lvm activate success message correctly Move the terminal.success to the methods that have access to the correct osd_id so that they do not print None for the osd_id in the log message. Signed-off-by: Andrew Schoen --- src/ceph-volume/ceph_volume/devices/lvm/activate.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ceph-volume/ceph_volume/devices/lvm/activate.py b/src/ceph-volume/ceph_volume/devices/lvm/activate.py index 2a7b0778bd7..c95cf799116 100644 --- a/src/ceph-volume/ceph_volume/devices/lvm/activate.py +++ b/src/ceph-volume/ceph_volume/devices/lvm/activate.py @@ -54,6 +54,7 @@ def activate_filestore(lvs): # start the OSD systemctl.start_osd(osd_id) + terminal.success("ceph-volume lvm activate successful for osd ID: %s" % osd_id) def get_osd_device_path(osd_lv, lvs, device_type): @@ -126,6 +127,7 @@ def activate_bluestore(lvs): # start the OSD systemctl.start_osd(osd_id) + terminal.success("ceph-volume lvm activate successful for osd ID: %s" % osd_id) class Activate(object): @@ -161,7 +163,6 @@ class Activate(object): activate_bluestore(lvs) elif args.filestore: activate_filestore(lvs) - terminal.success("ceph-volume lvm activate successful for osd ID: %s" % args.osd_id) def main(self): sub_command_help = dedent(""" -- 2.39.5