From cbb32a92a616d73ef49e019dacbb1a2d486db1eb Mon Sep 17 00:00:00 2001 From: Radoslaw Zarzynski Date: Tue, 7 Feb 2017 14:25:43 +0100 Subject: [PATCH] rgw: improve logs in rgw::auth::Strategy. Signed-off-by: Radoslaw Zarzynski --- src/rgw/rgw_auth.cc | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/rgw/rgw_auth.cc b/src/rgw/rgw_auth.cc index 20087519bd2..5e525e09a55 100644 --- a/src/rgw/rgw_auth.cc +++ b/src/rgw/rgw_auth.cc @@ -187,6 +187,8 @@ rgw::auth::Strategy::authenticate(const req_state* const s) const const rgw::auth::Engine& engine = kv.first; const auto& policy = kv.second; + dout(20) << get_name() << ": trying " << engine.get_name() << dendl; + result_t engine_result = result_t::deny(); try { engine_result = engine.authenticate(s); @@ -196,23 +198,35 @@ rgw::auth::Strategy::authenticate(const req_state* const s) const bool try_next = true; switch (engine_result.get_status()) { - case result_t::Status::REJECTED: + case result_t::Status::REJECTED: { + dout(20) << engine.get_name() << " rejected with reason=" + << engine_result.get_reason() << dendl; + std::tie(try_next, strategy_result) = \ strategy_handle_rejected(std::move(engine_result), policy, std::move(strategy_result)); - break; - case result_t::Status::DENIED: + break; + } + case result_t::Status::DENIED: { + dout(20) << engine.get_name() << " denied with reason=" + << engine_result.get_reason() << dendl; + std::tie(try_next, strategy_result) = \ strategy_handle_denied(std::move(engine_result), policy, std::move(strategy_result)); - break; - case result_t::Status::GRANTED: + break; + } + case result_t::Status::GRANTED: { + dout(20) << engine.get_name() << " granted access" << dendl; + std::tie(try_next, strategy_result) = \ strategy_handle_granted(std::move(engine_result), policy, std::move(strategy_result)); - break; - default: + break; + } + default: { abort(); + } } if (! try_next) { -- 2.47.3