From cbc36a786d65d5d1993f201c6eb8bdf9d371c2a1 Mon Sep 17 00:00:00 2001 From: sp98 Date: Thu, 7 Dec 2023 16:18:05 +0530 Subject: [PATCH] mds: change priority of mds rss perf counter to useful mds_cache_mem_rss perf counter can be a useful metric to detect the usage of mds cache and detect mds cache oversize before it happens. The PR changes the priority of the mds_rss metric from Debug to useful Fixes: https://tracker.ceph.com/issues/63765 Signed-off-by: sp98 (cherry picked from commit 89b9fa299c0fe80b3e8619dd9dd8cb77e5b08016) --- src/mds/MDSRank.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mds/MDSRank.cc b/src/mds/MDSRank.cc index a157563e439be..3d34772efdde2 100644 --- a/src/mds/MDSRank.cc +++ b/src/mds/MDSRank.cc @@ -3506,6 +3506,9 @@ void MDSRank::create_logger() PerfCountersBuilder::PRIO_INTERESTING); mdm_plb.add_u64(l_mdm_dn, "dn", "Dentries", "dn", PerfCountersBuilder::PRIO_INTERESTING); + // mds rss metric is set to PRIO_USEFUL as it can be useful to detect mds cache oversizing + mdm_plb.add_u64(l_mdm_rss, "rss", "RSS", "rss", + PerfCountersBuilder::PRIO_USEFUL); mdm_plb.set_prio_default(PerfCountersBuilder::PRIO_USEFUL); mdm_plb.add_u64_counter(l_mdm_inoa, "ino+", "Inodes opened"); @@ -3520,9 +3523,6 @@ void MDSRank::create_logger() mdm_plb.add_u64_counter(l_mdm_caps, "cap-", "Capabilities removed"); mdm_plb.add_u64(l_mdm_heap, "heap", "Heap size"); - mdm_plb.set_prio_default(PerfCountersBuilder::PRIO_DEBUGONLY); - mdm_plb.add_u64(l_mdm_rss, "rss", "RSS"); - mlogger = mdm_plb.create_perf_counters(); g_ceph_context->get_perfcounters_collection()->add(mlogger); } -- 2.39.5