From cc8dae1d89a6cc44f6133a10424d767fc3291dd2 Mon Sep 17 00:00:00 2001 From: Jianpeng Ma Date: Sun, 28 Nov 2021 13:00:14 +0800 Subject: [PATCH] librbd/cache/pwl: revert patch 76f4d29d92be3f9f45767cb1ac6cc50. In fact, After BlockGuard to fix flush reorder issue, patch 76f4d29d9 don't need. So revert. Signed-off-by: Jianpeng Ma --- src/librbd/cache/pwl/AbstractWriteLog.cc | 5 ----- src/librbd/cache/pwl/AbstractWriteLog.h | 1 - src/librbd/cache/pwl/rwl/WriteLog.cc | 1 - src/librbd/cache/pwl/ssd/WriteLog.cc | 3 --- 4 files changed, 10 deletions(-) diff --git a/src/librbd/cache/pwl/AbstractWriteLog.cc b/src/librbd/cache/pwl/AbstractWriteLog.cc index 981571bbec9..8194cc115fa 100644 --- a/src/librbd/cache/pwl/AbstractWriteLog.cc +++ b/src/librbd/cache/pwl/AbstractWriteLog.cc @@ -1745,10 +1745,6 @@ void AbstractWriteLog::process_writeback_dirty_entries() { break; } - if (m_flush_ops_will_send) { - ldout(cct, 20) << "Previous flush-ops is still not sent" << dendl; - break; - } auto candidate = m_dirty_log_entries.front(); bool flushable = can_flush_entry(candidate); if (flushable) { @@ -1765,7 +1761,6 @@ void AbstractWriteLog::process_writeback_dirty_entries() { m_lowest_flushing_sync_gen = candidate->ram_entry.sync_gen_number; } m_flush_ops_in_flight += 1; - m_flush_ops_will_send += 1; /* For write same this is the bytes affected by the flush op, not the bytes transferred */ m_flush_bytes_in_flight += candidate->ram_entry.write_bytes; } diff --git a/src/librbd/cache/pwl/AbstractWriteLog.h b/src/librbd/cache/pwl/AbstractWriteLog.h index e6656223402..e53c6320694 100644 --- a/src/librbd/cache/pwl/AbstractWriteLog.h +++ b/src/librbd/cache/pwl/AbstractWriteLog.h @@ -296,7 +296,6 @@ protected: std::atomic m_async_flush_ops = {0}; std::atomic m_async_append_ops = {0}; - std::atomic m_flush_ops_will_send = {0}; /* Acquire locks in order declared here */ mutable ceph::mutex m_log_retire_lock; diff --git a/src/librbd/cache/pwl/rwl/WriteLog.cc b/src/librbd/cache/pwl/rwl/WriteLog.cc index d5b5f712bb1..b2db20c3d49 100644 --- a/src/librbd/cache/pwl/rwl/WriteLog.cc +++ b/src/librbd/cache/pwl/rwl/WriteLog.cc @@ -596,7 +596,6 @@ void WriteLog::construct_flush_entries(pwl::GenericLogEntries entries_to_flus ldout(m_image_ctx.cct, 15) << "flushing:" << log_entry << " " << *log_entry << dendl; log_entry->writeback(this->m_image_writeback, ctx); - this->m_flush_ops_will_send -= 1; }), 0); }); } diff --git a/src/librbd/cache/pwl/ssd/WriteLog.cc b/src/librbd/cache/pwl/ssd/WriteLog.cc index 3046a7edf61..62e98e5dfe8 100644 --- a/src/librbd/cache/pwl/ssd/WriteLog.cc +++ b/src/librbd/cache/pwl/ssd/WriteLog.cc @@ -565,7 +565,6 @@ void WriteLog::construct_flush_entries(pwl::GenericLogEntries entries_to_flus ldout(m_image_ctx.cct, 15) << "flushing:" << log_entry << " " << *log_entry << dendl; log_entry->writeback(this->m_image_writeback, ctx); - this->m_flush_ops_will_send -= 1; }), 0); }); } @@ -614,7 +613,6 @@ void WriteLog::construct_flush_entries(pwl::GenericLogEntries entries_to_flus << " " << *log_entry << dendl; log_entry->writeback_bl(this->m_image_writeback, ctx, std::move(captured_entry_bl)); - this->m_flush_ops_will_send -= 1; }), 0); }); } else { @@ -627,7 +625,6 @@ void WriteLog::construct_flush_entries(pwl::GenericLogEntries entries_to_flus ldout(m_image_ctx.cct, 15) << "flushing:" << log_entry << " " << *log_entry << dendl; log_entry->writeback(this->m_image_writeback, ctx); - this->m_flush_ops_will_send -= 1; }), 0); }); } -- 2.39.5