From cd15405564746547abec07151154923d95a0a830 Mon Sep 17 00:00:00 2001 From: Sam Lang Date: Tue, 25 Sep 2012 19:32:52 -0700 Subject: [PATCH] client: Fix coverity UNINIT_CTOR defects Coverity finds cases where constructors are not initializing all the members of the struct/class. Signed-off-by: Sam Lang --- src/client/Client.cc | 3 ++- src/client/Inode.h | 5 +++-- src/client/Trace.h | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/client/Client.cc b/src/client/Client.cc index 67ababa818913..223df240975b7 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -101,7 +101,7 @@ void client_flush_set_callback(void *p, ObjectCacher::ObjectSet *oset) // ------------- dir_result_t::dir_result_t(Inode *in) - : inode(in), offset(0), next_offset(2), + : inode(in), offset(0), this_offset(2), next_offset(2), release_count(0), start_shared_gen(0), buffer(0) { inode->get(); @@ -114,6 +114,7 @@ dir_result_t::dir_result_t(Inode *in) Client::Client(Messenger *m, MonClient *mc) : Dispatcher(m->cct), cct(m->cct), logger(NULL), timer(m->cct, client_lock), ino_invalidate_cb(NULL), + ino_invalidate_cb_handle(NULL), tick_event(NULL), monclient(mc), messenger(m), whoami(m->get_myname().num()), initialized(false), mounted(false), unmounting(false), diff --git a/src/client/Inode.h b/src/client/Inode.h index b196d53ef9e38..7a382f722b3b9 100644 --- a/src/client/Inode.h +++ b/src/client/Inode.h @@ -29,7 +29,7 @@ struct Cap { __u32 mseq; // migration seq __u32 gen; - Cap() : session(NULL), inode(NULL), cap_item(this), issued(0), + Cap() : session(NULL), inode(NULL), cap_item(this), cap_id(0), issued(0), implemented(0), wanted(0), seq(0), issue_seq(0), mseq(0), gen(0) {} }; @@ -188,7 +188,8 @@ class Inode { Inode(CephContext *cct_, vinodeno_t vino, ceph_file_layout *layout) : cct(cct_), ino(vino.ino), snapid(vino.snapid), - rdev(0), mode(0), uid(0), gid(0), nlink(0), size(0), truncate_seq(1), truncate_size(-1), + rdev(0), mode(0), uid(0), gid(0), nlink(0), dir_layout({0}), layout({0}), + size(0), truncate_seq(1), truncate_size(-1), time_warp_seq(0), max_size(0), version(0), xattr_version(0), flags(0), dir_hashed(false), dir_replicated(false), auth_cap(NULL), diff --git a/src/client/Trace.h b/src/client/Trace.h index dc3ac22e6f2f7..c4a0f9e1532c9 100644 --- a/src/client/Trace.h +++ b/src/client/Trace.h @@ -39,7 +39,7 @@ class Trace { string line; public: - Trace(const char* f) : filename(f), fs(0) {} + Trace(const char* f) : _line(0), filename(f), fs(0) {} ~Trace() { delete fs; } -- 2.39.5