From cf744cc0f6f7d6e5926eccdb9d039436880735a5 Mon Sep 17 00:00:00 2001 From: Yehuda Sadeh Date: Thu, 22 Oct 2009 11:50:41 -0700 Subject: [PATCH] auth: fix uninitialized var, bad interface use --- src/mon/Monitor.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc index 00096049fca52..93f30134ed1c0 100644 --- a/src/mon/Monitor.cc +++ b/src/mon/Monitor.cc @@ -892,7 +892,7 @@ int Monitor::do_authorize(bufferlist::iterator& indata, bufferlist& result_bl) ::decode(cephx_header, indata); uint16_t request_type = cephx_header.request_type & CEPHX_REQUEST_TYPE_MASK; - int ret; + int ret = 0; dout(0) << "request_type=" << request_type << dendl; @@ -903,7 +903,8 @@ int Monitor::do_authorize(bufferlist::iterator& indata, bufferlist& result_bl) AuthServiceTicketInfo auth_ticket_info; bufferlist tmp_bl; - ret = verify_authorizer(key_server, indata, auth_ticket_info, tmp_bl); + if (!verify_authorizer(key_server, indata, auth_ticket_info, tmp_bl)) + ret = -EPERM; result_bl.claim_append(tmp_bl); } break; -- 2.39.5