From cfdd87cac9c24365700a28d6138665f4a6ae07b9 Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Fri, 31 May 2013 19:07:45 +0200 Subject: [PATCH] mds/Server.cc: fix dereference after null check CID 716927 (#1 of 1): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointer "diri->snaprealm" to function "SnapRealm::resolve_snapname(std::string const & Make sure not to dereference diri->snaprealm. Signed-off-by: Danny Al-Gaaf --- src/mds/Server.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mds/Server.cc b/src/mds/Server.cc index 5b23b7ff8372..abeea2c12d5f 100644 --- a/src/mds/Server.cc +++ b/src/mds/Server.cc @@ -7445,8 +7445,7 @@ void Server::handle_client_rmsnap(MDRequest *mdr) reply_request(mdr, -EINVAL); // can't prune a parent snap, currently. return; } - if (diri->snaprealm && - !diri->snaprealm->exists(snapname)) { + if (!diri->snaprealm || !diri->snaprealm->exists(snapname)) { reply_request(mdr, -ENOENT); return; } -- 2.47.3