From d019cd411869e44b6880c09757de299729396e75 Mon Sep 17 00:00:00 2001 From: Sun Ke Date: Wed, 23 Mar 2022 16:37:24 +0800 Subject: [PATCH] generic/066: attr1 is still there after log replay on f2fs The test fail on f2fs: xattr names and values after second fsync log replay: # file: SCRATCH_MNT/foobar +user.attr1="val1" user.attr3="val3" attr1 is still there after log replay. f2fs doesn't support fs-op level transaction functionality. so it have no way to persist all metadata updates in one transaction. We can use "fastboot" mountoption for this case, so during last fsync on qwerty, f2fs can trigger a checkpoint which will persist all metadata updates before fsync(). Suggested-by: Chao Yu Signed-off-by: Sun Ke Reviewed-by: Chao Yu Signed-off-by: Eryu Guan --- tests/generic/066 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/generic/066 b/tests/generic/066 index 105a7acd..d8a38655 100755 --- a/tests/generic/066 +++ b/tests/generic/066 @@ -56,6 +56,14 @@ sync $SETFATTR_PROG -x user.attr2 $SCRATCH_MNT/foobar $XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foobar +# f2fs doesn't support fs-op level transaction functionality. so it have no way +# to persist all metadata updates in one transaction. We can use "fastboot" +# mountoption for this case, so during last fsync on qwerty, f2fs can trigger a +# checkpoint which will persist all metadata updates before fsync(). +if [ $FSTYP = "f2fs" ]; then + export MOUNT_OPTIONS="-o fastboot $MOUNT_OPTIONS" +fi + _flakey_drop_and_remount # After the fsync log is replayed, the file should have only 2 xattrs, the ones -- 2.39.5