From d0a8ee9bc68e1fdecffce7b0424bf3ed7c211cb5 Mon Sep 17 00:00:00 2001
From: Tiago Melo <tmelo@suse.com>
Date: Wed, 2 Oct 2019 10:51:07 +0000
Subject: [PATCH] mgr/dashboard: Provide TRANSLATIONS directly in app.module.ts

Remove LOCALE_ID from provide list, since this is now defined during build.

Signed-off-by: Tiago Melo <tmelo@suse.com>
---
 .../dashboard/frontend/src/app/app.module.ts  | 23 ++++++++++++++++---
 .../frontend/src/app/locale.helper.ts         | 22 ------------------
 2 files changed, 20 insertions(+), 25 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/app.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/app.module.ts
index 12a4d9434e7..fc4796a4ca5 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/app.module.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/app.module.ts
@@ -1,5 +1,11 @@
 import { HTTP_INTERCEPTORS, HttpClientModule } from '@angular/common/http';
-import { ErrorHandler, NgModule } from '@angular/core';
+import {
+  ErrorHandler,
+  LOCALE_ID,
+  NgModule,
+  TRANSLATIONS,
+  TRANSLATIONS_FORMAT
+} from '@angular/core';
 import { BrowserModule } from '@angular/platform-browser';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 
@@ -18,7 +24,6 @@ import { AppRoutingModule } from './app-routing.module';
 import { AppComponent } from './app.component';
 import { CephModule } from './ceph/ceph.module';
 import { CoreModule } from './core/core.module';
-import { i18nProviders } from './locale.helper';
 import { ApiInterceptorService } from './shared/services/api-interceptor.service';
 import { JsErrorHandler } from './shared/services/js-error-handler.service';
 import { SharedModule } from './shared/shared.module';
@@ -66,7 +71,19 @@ export function jwtTokenGetter() {
       useClass: ApiInterceptorService,
       multi: true
     },
-    i18nProviders,
+    {
+      provide: TRANSLATIONS,
+      useFactory: (locale) => {
+        locale = locale || 'en-US';
+        try {
+          return require(`raw-loader!locale/messages.${locale}.xlf`).default;
+        } catch (error) {
+          return [];
+        }
+      },
+      deps: [LOCALE_ID]
+    },
+    { provide: TRANSLATIONS_FORMAT, useValue: 'xlf' },
     I18n
   ],
   bootstrap: [AppComponent]
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/locale.helper.ts b/src/pybind/mgr/dashboard/frontend/src/app/locale.helper.ts
index 6598e1cd733..7629f87e629 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/locale.helper.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/locale.helper.ts
@@ -1,7 +1,3 @@
-import { LOCALE_ID, TRANSLATIONS, TRANSLATIONS_FORMAT } from '@angular/core';
-
-declare const require;
-
 export class LocaleHelper {
   static getBrowserLang(): string {
     const lang = navigator.language;
@@ -45,21 +41,3 @@ export class LocaleHelper {
   }
 }
 
-const i18nProviders = [
-  { provide: LOCALE_ID, useValue: LocaleHelper.getLocale() },
-  {
-    provide: TRANSLATIONS,
-    useFactory: (locale) => {
-      locale = locale || 'en-US';
-      try {
-        return require(`raw-loader!locale/messages.${locale}.xlf`).default;
-      } catch (error) {
-        return [];
-      }
-    },
-    deps: [LOCALE_ID]
-  },
-  { provide: TRANSLATIONS_FORMAT, useValue: 'xlf' }
-];
-
-export { i18nProviders };
-- 
2.39.5