From d0cf2bfb3206d90123b448732bd243ce73631d0c Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Tue, 5 Nov 2013 19:51:14 +0100 Subject: [PATCH] ErasureCodeExample.h: prefer prefix ++operator for non-primitive types Prefer prefix ++operator for non-primitive types like iterators for performance reasons. Prefix ++/-- operators avoid creating a temporary copy. Signed-off-by: Danny Al-Gaaf --- src/test/osd/ErasureCodeExample.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/osd/ErasureCodeExample.h b/src/test/osd/ErasureCodeExample.h index 0fd55187559..07694ea409a 100644 --- a/src/test/osd/ErasureCodeExample.h +++ b/src/test/osd/ErasureCodeExample.h @@ -76,7 +76,7 @@ public: set available_chunks; for (map::const_iterator i = c2c.begin(); i != c2c.end(); - i++) + ++i) available_chunks.insert(i->first); return minimum_to_decode(want_to_read, available_chunks, minimum); } @@ -109,7 +109,7 @@ public: const bufferptr ptr = out.buffers().front(); for (set::iterator j = want_to_encode.begin(); j != want_to_encode.end(); - j++) { + ++j) { bufferptr chunk(ptr, (*j) * chunk_length, chunk_length); (*encoded)[*j].push_front(chunk); } @@ -125,7 +125,7 @@ public: unsigned chunk_length = (*chunks.begin()).second.length(); for (set::iterator i = want_to_read.begin(); i != want_to_read.end(); - i++) { + ++i) { if (chunks.find(*i) != chunks.end()) { // // If the chunk is available, just copy the bufferptr pointer @@ -146,7 +146,7 @@ public: bufferptr chunk(chunk_length); map::const_iterator k = chunks.begin(); const char *a = k->second.buffers().front().c_str(); - k++; + ++k; const char *b = k->second.buffers().front().c_str(); for (unsigned j = 0; j < chunk_length; j++) { chunk[j] = a[j] ^ b[j]; -- 2.47.3