From d19b998dd712aa9ade2784dd46d646b8fff12dc4 Mon Sep 17 00:00:00 2001 From: Adam Kupczyk Date: Wed, 22 May 2024 17:59:52 +0200 Subject: [PATCH] os/bluestore: Writer, rename _deferred_decision -> _defer_or_allocate A review proposal. Signed-off-by: Adam Kupczyk --- src/os/bluestore/Writer.cc | 6 ++++-- src/os/bluestore/Writer.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/os/bluestore/Writer.cc b/src/os/bluestore/Writer.cc index 63e1e5b891b97..9cfb25edb666e 100644 --- a/src/os/bluestore/Writer.cc +++ b/src/os/bluestore/Writer.cc @@ -1180,11 +1180,13 @@ std::pair BlueStore::Writer::_write_expand_r( return std::make_pair(new_data_pad, new_data_end); } + + // This function is a centralized place to make a decision on // whether to use deferred or direct writes. // The assumption behind it is that having parts of write executed as // deferred and other parts as direct is suboptimal in any case. -void BlueStore::Writer::_deferred_decision(uint32_t need_size) +void BlueStore::Writer::_defer_or_allocate(uint32_t need_size) { // make a deferred decision uint32_t released_size = 0; @@ -1314,7 +1316,7 @@ void BlueStore::Writer::do_write( if (location != data_end) { uint32_t need_size = p2roundup(data_end, au_size) - p2align(location, au_size); // make a deferred decision - _deferred_decision(need_size); + _defer_or_allocate(need_size); _do_put_blobs(location, data_end, ref_end, bd, after_punch_it); } else { // Unlikely, but we just put everything. diff --git a/src/os/bluestore/Writer.h b/src/os/bluestore/Writer.h index 79f24b52d22c6..d2372e4ac7381 100644 --- a/src/os/bluestore/Writer.h +++ b/src/os/bluestore/Writer.h @@ -202,7 +202,7 @@ private: void _collect_released_allocated(); - void _deferred_decision(uint32_t need_size); + void _defer_or_allocate(uint32_t need_size); }; std::ostream& operator<<(std::ostream& out, const BlueStore::Writer::blob_data_printer& printer); -- 2.39.5