From d206992bd0e670314207363fa1e18506de4ae70f Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Fri, 1 Mar 2019 11:59:39 +0100 Subject: [PATCH] src/script: add run_mypy to run static type checking on Python code Signed-off-by: Sebastian Wagner --- src/pybind/mgr/orchestrator.py | 2 +- src/script/run_mypy.sh | 37 ++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100755 src/script/run_mypy.sh diff --git a/src/pybind/mgr/orchestrator.py b/src/pybind/mgr/orchestrator.py index 598181b501e79..ae215f968fe32 100644 --- a/src/pybind/mgr/orchestrator.py +++ b/src/pybind/mgr/orchestrator.py @@ -710,7 +710,7 @@ class InventoryDevice(object): def __init__(self, blank=False, type=None, id=None, size=None, rotates=False, available=False, dev_id=None, extended=None, metadata_space_free=None): - # type: (bool, str, str, int, bool, bool. str, dict, bool) -> None + # type: (bool, str, str, int, bool, bool, str, dict, bool) -> None self.blank = blank diff --git a/src/script/run_mypy.sh b/src/script/run_mypy.sh new file mode 100755 index 0000000000000..3d13532891b8b --- /dev/null +++ b/src/script/run_mypy.sh @@ -0,0 +1,37 @@ +#!/usr/bin/env bash + +# needs to be executed form the src directory. +# generates a report at src/mypy_report.txt + +python3 -m venv venv + +. venv/bin/activate + +pip install $(find * -name requirements.txt | awk '{print "-r " $0}') mypy + +cat < ./mypy.ini +[mypy] +strict_optional = True +no_implicit_optional = True +ignore_missing_imports = True +warn_incomplete_stub = True +check_untyped_defs = True +show_error_context = True +EOF + + +echo "pybind:" > mypy_report.txt +pushd pybind +mypy --config-file=../mypy.ini *.py | awk '{print "pybind/" $0}' >> ../mypy_report.txt +popd + +echo "MGR Modules:" >> mypy_report.txt +pushd pybind/mgr +mypy --config-file=../../mypy.ini $(find * -name '*.py' | grep -v -e venv -e tox -e env -e gyp -e node_modules) | awk '{print "pybind/mgr/" $0}' >> ../../mypy_report.txt +popd + +echo "ceph-volume:" >> mypy_report.txt +pushd ceph-volume/ceph_volume +mypy --config-file=../../mypy.ini $(find * -name '*.py' | grep -v -e venv -e tox -e env -e gyp -e node_modules -e tests) | awk '{print "ceph-volume/ceph_volume/" $0}' >> ../../mypy_report.txt +popd + -- 2.39.5