From d36bab5557e9fc9c50c5db29d1331f90e9285ced Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Fri, 7 Jun 2019 10:50:28 +0200 Subject: [PATCH] validate: fail in check_devices at the right task see https://bugzilla.redhat.com/show_bug.cgi?id=1648168#c17 for details. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1648168#c17 Signed-off-by: Guillaume Abrioux (cherry picked from commit 771648304d7d867e053f8b8fe3ce5b36e061f100) --- roles/ceph-validate/tasks/check_devices.yml | 27 ++++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/roles/ceph-validate/tasks/check_devices.yml b/roles/ceph-validate/tasks/check_devices.yml index 6d938499e..8b3286c5e 100644 --- a/roles/ceph-validate/tasks/check_devices.yml +++ b/roles/ceph-validate/tasks/check_devices.yml @@ -1,14 +1,17 @@ --- -- name: validate devices is actually a device - parted: - device: "{{ item }}" - unit: MiB - register: devices_parted - with_items: "{{ devices }}" +- name: devices validation + when: devices is defined + block: + - name: get devices information + parted: + device: "{{ item }}" + unit: MiB + register: devices_parted + failed_when: False + with_items: "{{ devices }}" -- name: fail if one of the devices is not a device - fail: - msg: "{{ item }} is not a block special file!" - when: - - item.failed - with_items: "{{ devices_parted.results }}" + - name: fail if one of the devices is not a device + fail: + msg: "{{ item }} is not a block special file!" + when: item.rc is defined + with_items: "{{ devices_parted.results }}" -- 2.39.5