From d4afcccf14cdcf3352941e97e36628fa44ea15b3 Mon Sep 17 00:00:00 2001 From: Nitzan Mordechai Date: Thu, 20 Feb 2025 07:37:45 +0000 Subject: [PATCH] LogMonitor: set no_reply for forward MLog commands On streach mod clusters we can see slow ops when removing and adding osds with --zap --force when osds connected to peon monitor and forwarding the MLog to leader. the no_reply is set only when we are connected to the leader, this fix will add also the other option - so no_reply set anyway. Fixes: https://tracker.ceph.com/issues/54489 Signed-off-by: Nitzan Mordechai (cherry picked from commit 56cb53db96380c917f4192c31cbdd0f0f3ef1fe9) --- src/mon/LogMonitor.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mon/LogMonitor.cc b/src/mon/LogMonitor.cc index 654ee4c6910..c671ce8fb40 100644 --- a/src/mon/LogMonitor.cc +++ b/src/mon/LogMonitor.cc @@ -711,11 +711,9 @@ bool LogMonitor::preprocess_log(MonOpRequestRef op) goto done; } - return false; - - done: - mon.no_reply(op); - return true; + done: + mon.no_reply(op); + return (!num_new); } struct LogMonitor::C_Log : public C_MonOp { -- 2.39.5