From d4b2b1ab620d76ef44c0cf91064fae6a246e42b4 Mon Sep 17 00:00:00 2001 From: Laura Flores Date: Mon, 4 Oct 2021 04:41:10 +0000 Subject: [PATCH] os/bluestore: update priorities and nicks of bluestore perf counters These perf counters do not show up in telemetry unless they are set to a "useful" priority or higher. Fetching these counters in telemetry may help to diagnose problems with RocksDB / BlueFS prefetching / insufficient cache sizes. Signed-off-by: Laura Flores (cherry picked from commit 8790f04c5469d86daebb3bbe1eb780a86b7404ce) Note: This backport (and the original PR) exposed an extra 34 perf counters/OSD to Prometheus. Given Pacific is a stable release and not to add that much extra load we are adapting this backport and only exposing the 2 required perf-coun> --- src/os/bluestore/BlueStore.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc index b9ee17fbfe830..4dc3015a1c3ba 100644 --- a/src/os/bluestore/BlueStore.cc +++ b/src/os/bluestore/BlueStore.cc @@ -4954,9 +4954,11 @@ void BlueStore::_init_logger() b.add_u64(l_bluestore_pinned_onodes, "bluestore_pinned_onodes", "Number of pinned onodes in cache"); b.add_u64_counter(l_bluestore_onode_hits, "bluestore_onode_hits", - "Sum for onode-lookups hit in the cache"); + "Count of onode cache lookup hits", + "o_ht", PerfCountersBuilder::PRIO_USEFUL); b.add_u64_counter(l_bluestore_onode_misses, "bluestore_onode_misses", - "Sum for onode-lookups missed in the cache"); + "Count of onode cache lookup misses", + "o_ms", PerfCountersBuilder::PRIO_USEFUL); b.add_u64_counter(l_bluestore_onode_shard_hits, "bluestore_onode_shard_hits", "Sum for onode-shard lookups hit in the cache"); b.add_u64_counter(l_bluestore_onode_shard_misses, -- 2.39.5